Skip to content

fix: Use strict comparaison#7593

Merged
grnd-alt merged 1 commit intomainfrom
carl/in_array_true
Jan 28, 2026
Merged

fix: Use strict comparaison#7593
grnd-alt merged 1 commit intomainfrom
carl/in_array_true

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Jan 28, 2026

Summary

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@CarlSchwan CarlSchwan self-assigned this Jan 28, 2026
@CarlSchwan CarlSchwan requested review from juliusknorr and luka-nextcloud and removed request for elzody, grnd-alt and luka-nextcloud January 28, 2026 11:25
@grnd-alt grnd-alt force-pushed the carl/in_array_true branch 3 times, most recently from e141f2e to 729a4b4 Compare January 28, 2026 13:20
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84278 was 83517 (+0.91%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt grnd-alt self-requested a review January 28, 2026 13:21
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84282 was 83517 (+0.91%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84278 was 83517 (+0.91%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

grnd-alt
grnd-alt requested changes Jan 28, 2026
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 84323 was 83517 (+0.96%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@CarlSchwan
fix: Use strict comparaison
3458918 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@grnd-alt grnd-alt self-requested a review January 28, 2026 14:38
@grnd-alt grnd-alt merged commit fbed258 into main Jan 28, 2026
40 of 42 checks passed
@grnd-alt grnd-alt deleted the carl/in_array_true branch January 28, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud luka-nextcloud is a code owner

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CarlSchwan @grnd-alt